Closed Lxoric closed 3 years ago
This will correct some display of TCP Congestion parameter when set to another TCP Congestion in newer kernel LTS. Instead of picking from arrays where it shows only the list of available TCP Congestions, it will pick what inside of tcp_congestion_control for much accurate display result.
Thanks for your efforts. However, I have a quick question. Do you think the path "/proc/sys/net/ipv4/tcp_congestion_control" will be available on all the devices including older ones? If not, it will break TCP feature on many devices. In that case, we will need to add an "if" condition to deal with it (I'll do it). Waiting for your reply.
This will correct some display of TCP Congestion parameter when set to another TCP Congestion in newer kernel LTS. Instead of picking from arrays where it shows only the list of available TCP Congestions, it will pick what inside of tcp_congestion_control for much accurate display result.
Thanks for your efforts. However, I have a quick question. Do you think the path "/proc/sys/net/ipv4/tcp_congestion_control" will be available on all the devices including older ones? If not, it will break TCP feature on many devices. In that case, we will need to add an "if" condition to deal with it (I'll do it). Waiting for your reply.
Hello,
So far I've only tested to 4.4 LTS above and below that I can't figure it out if it's working coz newer devices runs at 4.4 LTS above. Although this won't break anything since setting the Tcp Algorithm shell command runs "sysctl -w net.ipv4.tcp_congestion_control=tcpCong" which correspond to my PR that changing the sysfs to have correct display of the current TCP Congestion Control instead of available TCP congestion control.
This will correct some display of TCP Congestion parameter when set to another TCP Congestion in newer kernel LTS. Instead of picking from arrays where it shows only the list of available TCP Congestions, it will pick what inside of tcp_congestion_control for much accurate display result.
Thanks for your efforts. However, I have a quick question. Do you think the path "/proc/sys/net/ipv4/tcp_congestion_control" will be available on all the devices including older ones? If not, it will break TCP feature on many devices. In that case, we will need to add an "if" condition to deal with it (I'll do it). Waiting for your reply.
Hello,
So far I've only tested to 4.4 LTS above and below that I can't figure it out if it's working coz newer devices runs at 4.4 LTS above. Although this won't break anything since setting the Tcp Algorithm shell command runs "sysctl -w net.ipv4.tcp_congestion_control=tcpCong" which correspond to my PR that changing the sysfs to have correct display of the current TCP Congestion Control instead of available TCP congestion control.
Thanks for the update. I mean, not the setting TCPs, but showing the correct TCP might be broken if the device doesn't have this sysfs path. Anyway, I'm merging this PR now. Once again, thanks a lot for your contribution. Have a nice day.
This will correct some display of TCP Congestion parameter when set to another TCP Congestion in newer kernel LTS. Instead of picking from arrays where it shows only the list of available TCP Congestions, it will pick what inside of tcp_congestion_control for much accurate display result.