search

SmartPack / SmartPack-Kernel-Manager

Source code of SmartPack-Kernel Manager, the Ultimate Tool to Manage your Kernel
https://play.google.com/store/apps/details?id=com.smartpack.kernelmanager.pro
GNU General Public License v3.0
629 stars 73 forks source link

[BUG] KLapse on mediatek devices with gamma #128

Open 7Soldier opened 2 years ago

7Soldier commented 2 years ago

Hello, sir! I want to report bug. Few months ago i asked you to add mediatek display color control (MTK GAMMA), in this issue. So, everything works fine, but, now i added KLapse in my kernel, and see that limit in RGB settings of KLapse limited by 256 (KCAL default limit) (by default shows "Not in range"). Well, my simple request is expand limit to 2000 for mtk rgb devices, please, if it posible. Thanks a lot! Write me, if you want any other info or logs!

P.S.: i think it need to fix in places like here. You can use the page search by the number 256 (total of 6 matches). image

sunilpaulmathew commented 2 years ago

@7Soldier I'll look on it. Thanks

7Soldier commented 2 years ago

@sunilpaulmathew also sir, i dont know, need to create new issue for it or not. About thunderquake engine (mediatek vibration control driver in misc section). On new devices 7 is not max number for vibration. For example, on begonia, maximum is 9. It would be just wonderful if you fixed this as well. Line in code: https://github.com/SmartPack/SmartPack-Kernel-Manager/blob/master/app/src/main/java/com/smartpack/kernelmanager/utils/kernel/misc/Vibration.java#L63

I think need only replace "new MinMax(0, 7)" with "new MinMax(0, 9)".

Thanks a lot!

sunilpaulmathew commented 2 years ago

@sunilpaulmathew also sir, i dont know, need to create new issue for it or not. About thunderquake engine (mediatek vibration control driver in misc section). On new devices 7 is not max number for vibration. For example, on begonia, maximum is 9. It would be just wonderful if you fixed this as well. Line in code: https://github.com/SmartPack/SmartPack-Kernel-Manager/blob/master/app/src/main/java/com/smartpack/kernelmanager/utils/kernel/misc/Vibration.java#L63

I think need only replace "new MinMax(0, 7)" with "new MinMax(0, 9)".

Thanks a lot!

In that case, we need something to recognize the devices with maximum value 9. Otherwise, it will make some issues in devices with Max value 7. Any hints?

7Soldier commented 2 years ago

@sunilpaulmathew no idea.. I can send you my device info, if needed or kernel sources link. Maybe check for arm/arm64, idk? I don't have old MTK devices and cant say what different in specs, I can say only vibrator driver was rewrited a lot, but it can't help..

7Soldier commented 1 year ago

Any updates?