search

SmartPack / SmartPack-Kernel-Manager

Source code of SmartPack-Kernel Manager, the Ultimate Tool to Manage your Kernel
https://play.google.com/store/apps/details?id=com.smartpack.kernelmanager.pro
GNU General Public License v3.0
653 stars 72 forks source link

added battery+ profile #4

Closed ghost closed 5 years ago

ghost commented 5 years ago

this will help maintain more battery life when there is very less battery left

sunilpaulmathew commented 5 years ago

Hi @abhijiths0098 Thank you very much for your efforts. However, I have some concerns before accepting your pull request, and are

  1. It is basically a deviation from the original implementation of spectrum app, which is currently followed in to many kernels. I guess, many kernel developers/maintainers, those who do not want to add one more spectrum profile, may not like this idea. Because, it will introduce a new profile (named Battery+) in to their devices with spectrum support (as per the current implementation of spectrum in this app), which is practically useless.
  2. I am also worried that it makes issues to the quick tile (may be you can check and confirm?)

Looking forward to your reply. sp

ghost commented 5 years ago

You are right it is not working . sorry for wasting your time

On Fri, 29 Mar, 2019, 8:17 AM sp, notifications@github.com wrote:

Hi @abhijiths0098 https://github.com/abhijiths0098 Thank you very much for your efforts. However, I have some concerns before accepting your pull request, and are

  1. It is basically a deviation from the original implementation of spectrum app, which is currently followed in to many kernels. I guess, many kernel developers/maintainers, those who do not want to add one more spectrum profile, may not like this idea. Because, it will introduce a new profile (named Battery+) in to their devices with spectrum support (as per the current implementation of spectrum in this app), which is practically useless.
  2. I am also worried that it makes issues to the quick tile (may be you can check and confirm?)

Looking forward to your reply. sp

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SmartPack/SmartPack-Kernel-Manager/pull/4#issuecomment-477845531, or mute the thread https://github.com/notifications/unsubscribe-auth/AsnzMF99CtHO5U_JDjQYc0E9pCXwnm_Lks5vbX6tgaJpZM4cQhP9 .

sunilpaulmathew commented 5 years ago

@abhijiths0098 No problem... & have a nice day...