search

SmartPack / SmartPack-Kernel-Manager

Source code of SmartPack-Kernel Manager, the Ultimate Tool to Manage your Kernel
https://play.google.com/store/apps/details?id=com.smartpack.kernelmanager.pro
GNU General Public License v3.0
639 stars 71 forks source link

bug I can't switch on/off adreno idle feature #85

Closed djemilbakhti closed 3 years ago

djemilbakhti commented 3 years ago

smart pack kernel manager send Y as parameters require a send 1 or 0 to work Screenshot_20201205-102434_Trebuchet Screenshot_20201205-102530_Trebuchet

sunilpaulmathew commented 3 years ago

@djemilbakhti Hi, thanks for raising the issue. I think the original AdrenoIdler uses "N" and "Y" for disable/enable. Is the one in your kernel is probably modified by the developer? I can fix it easily if you check and tell me the values are changed in the respective path even after sending "y" or "N" (instead of 1 or 0). Can you?

djemilbakhti commented 3 years ago

@djemilbakhti Hi, thanks for raising the issue. I think the original AdrenoIdler uses "N" and "Y" for disable/enable. Is the one in your kernel is probably modified by the developer? I can fix it easily if you check and tell me the values are changed in the respective path even after sending "y" or "N" (instead of 1 or 0). Can you?

this is patch adreno idler source code : https://github.com/silont-project/kernel_xiaomi_onclite/commit/4ec61d8054e6bd22f0f5636bc62b340869e1abb9#diff-4f57324cc52e69a61182ce37aea22845592c41a05e0eee6e56fa1a3833389da6

sunilpaulmathew commented 3 years ago

@djemilbakhti Hi, thanks for raising the issue. I think the original AdrenoIdler uses "N" and "Y" for disable/enable. Is the one in your kernel is probably modified by the developer? I can fix it easily if you check and tell me the values are changed in the respective path even after sending "y" or "N" (instead of 1 or 0). Can you?

this is patch adreno idler source code : silont-project/kernel_xiaomi_onclite@4ec61d8#diff-4f57324cc52e69a61182ce37aea22845592c41a05e0eee6e56fa1a3833389da6

I have nothing to do with it (or I have no capacity to deal with Kernel source). What I'm asking to you is

  1. Enable that switch in app (ofcourse, it won't work).
  2. Read the value of the sysfs (shown in the second screenshot) path and tell me if it is 1 or 0.

Thanks

djemilbakhti commented 3 years ago

@djemilbakhti Hi, thanks for raising the issue. I think the original AdrenoIdler uses "N" and "Y" for disable/enable. Is the one in your kernel is probably modified by the developer? I can fix it easily if you check and tell me the values are changed in the respective path even after sending "y" or "N" (instead of 1 or 0). Can you?

this is patch adreno idler source code : silont-project/kernel_xiaomi_onclite@4ec61d8#diff-4f57324cc52e69a61182ce37aea22845592c41a05e0eee6e56fa1a3833389da6

I have nothing to do with it (or I have no capacity to deal with Kernel source). What I'm asking to you is

  1. Enable that switch in app (ofcourse, it won't work).
  2. Read the value of the sysfs (shown in the second screenshot) path and tell me if it is 1 or 0.

Thanks

Screenshot_20201206-193334

djemilbakhti commented 3 years ago

Is show 1

sunilpaulmathew commented 3 years ago

Is show 1

Great That means, driver is indeed enabled. The issue is only on the display status. Will fix in next update. Thanks

sunilpaulmathew commented 3 years ago

Is show 1 If you wish, you can probably test this attached apk. Please Note: This is a beta-build. If you're on PlayStore version (stable), you will see two SPKM icons after installing this one due to the different package id.