SmartPack / SmartPack-Kernel-Manager

Source code of SmartPack-Kernel Manager, the Ultimate Tool to Manage your Kernel
https://play.google.com/store/apps/details?id=com.smartpack.kernelmanager.pro
GNU General Public License v3.0
639 stars 71 forks source link

Missing or Incorrect Boeffla Sound settings #89

Open Mibo5354 opened 3 years ago

Mibo5354 commented 3 years ago

Device: Samsung Galaxy S3 (i9300) ROM: LineageOS (Modified) Kernel: https://github.com/Mibo5354/android_kernel_samsung_smdk4412

Could the following settings be corrected or added to SmartPack Kernel Manager?

Change Speaker Gain to Speaker volume /sys/class/misc/boeffla_sound/speaker_volume Accepts 2 values one for left and one for right. E.g. 57 57 Maximum value: 63 Minimum value: 0

Change Headphone Gain to Headphone volume /sys/class/misc/boeffla_sound/headphone_volume Accepts 2 values one for left and one for right. E.g. 57 57 Maximum value: 63 Minimum value: 0

Change Microphone Gain (Calls) to Microphone Volume (Calls) /sys/class/misc/boeffla_sound/mic_level_call Maximum value: 31 Minimum value: 0

Add Microphone Volume (General) /sys/class/misc/boeffla_sound/mic_level_general Maximum value: 31 Minimum value: 0

The following toggles accepts 0 or 1, 0 for off 1 for on.

Speaker tuning /sys/class/misc/boeffla_sound/speaker_tuning

Privacy mode /sys/class/misc/boeffla_sound/privacy_mode

DAC direct /sys/class/misc/boeffla_sound/dac_direct

DAC oversampling /sys/class/misc/boeffla_sound/dac_oversampling

FLL tuning /sys/class/misc/boeffla_sound/fll_tuning

Mono downmix /sys/class/misc/boeffla_sound/mono_downmix

sunilpaulmathew commented 3 years ago

@Mibo5354 Thanks a lot for raising this issue. Unfortunately, there are some issues to deal with Boeffla sound. Some of the issues are

  1. The implementation of that feature on my app is mainly targeted for SGS5, and OP5T. That's why the features in the bottom part are missing (those are exclusive for SGS3).
  2. Changing the titles are difficult. It will make issues with translations in which I have very little control. Also, I'm following a general style which is also applicable for other sound drivers as well.
  3. In order to change the min and max values (which will conflict with the other mentioned devices), more work is needed. For that, I also need some thing to identify your device (device/board name etc.), I also want to see the exact outputs of all these paths to get little more idea.
  4. I can add the last 6 paths without issues, again after you showing me the output of those paths.
Mibo5354 commented 3 years ago

To identify the device, you could use the hardware name smdk4x12.

Here are the exact outputs: headphone_volume.txt mic_level_call.txt mic_level_general.txt mono_downmix.txt privacy_mode.txt speaker_tuning.txt speaker_volume.txt dac_direct.txt dac_oversampling.txt fll_tuning.txt

sunilpaulmathew commented 3 years ago

@Mibo5354 Can you test this and tell me if everything (except the headphone and speaker gain limits) are working.

Mibo5354 commented 3 years ago

Everything added is working correctly.

Thanks for working on this.

sunilpaulmathew commented 3 years ago

Everything added is working correctly.

Thanks for working on this.

Great, thanks for testing. Also, can you attach me a screenshot of your app's Device page. I'm worrying that the features like Speaker and Microphone Gain won't work properly without some work in kernel side.

Mibo5354 commented 3 years ago

Screenshot_20210131-093240 Screenshot_20210131-093246

sunilpaulmathew commented 3 years ago

@Mibo5354 Any chance to test this APK. Everything (including Speaker and Headphone) limits should be hopefully fixed. If it fine, I'll make it official. Thanks.

Mibo5354 commented 3 years ago

All the settings work. However, the speaker and headphone gain shows 0 when the app is first opened. Also can you change the limits for Microphone Gain (Calls) as well because the slider allows invalid negative values. Thanks.

sunilpaulmathew commented 3 years ago

All the settings work.

Wow, great. Thanks for testing.

However, the speaker and headphone gain shows 0 when the app is first opened.

It won't work properly unless you're kernel developer did some workaround. Please ask him to have a look on this commit

Also can you change the limits for Microphone Gain (Calls) as well because the slider allows invalid negative values.

Is the limit is 0 -31. I thought it's already done. I'll check.

sunilpaulmathew commented 3 years ago

@Mibo5354 Please test this one too. The mic gain limit should be fixed. https://www.dropbox.com/s/9tse8288dvs6f3d/com.smartpack.kernelmanager.apk?dl=0

Mibo5354 commented 3 years ago

Mic gain limit is fixed in the latest apk.

Headphone gain is fixed with the kernel commit but not speaker gain, that still shows 0.

sunilpaulmathew commented 3 years ago

Mic gain limit is fixed in the latest apk.

Headphone gain is fixed with the kernel commit but not speaker gain, that still shows 0.

Then, I have no idea at this moment. Will look into it later. I'll leave this issue open until then. Thanks a lot for helping me to improve my work.

Mibo5354 commented 3 years ago

I noticed that in version 15.7 that it is able to show the speaker gain value as "not in range" now that I've added the kernel patch. So in the older version it was able to read the value. However in 15.9 it only shows the 0 value.

sunilpaulmathew commented 3 years ago

I noticed that in version 15.7 that it is able to show the speaker gain value as "not in range" now that I've added the kernel patch. So in the older version it was able to read the value. However in 15.9 it only shows the 0 value.

I guess I got the issue. Will fix in future.

sunilpaulmathew commented 3 years ago

I noticed that in version 15.7 that it is able to show the speaker gain value as "not in range" now that I've added the kernel patch. So in the older version it was able to read the value. However in 15.9 it only shows the 0 value.

Can you test this apk to check the speaker gain issue is fixed?

Mibo5354 commented 3 years ago

This apk shows "Not in range" now. So it can read the value but the seek bar is still from -30 to 30 instead of 0 to 64.