SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
268 stars 453 forks source link

Matter Switch: add support for additional switch device types #1376

Closed hcarter-775 closed 5 months ago

hcarter-775 commented 5 months ago

The Dimmer Switch and Color Dimmer Switch both support the OnOff cluster as client, but some devices in the field support them as server. These changes accomodate that discrepancy. Changes for OnOff Switch device type were originally commited here: cda431bf5496f002fab8d91d31a4df95c790abbc

https://smartthings.atlassian.net/browse/CHAD-13121

CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

github-actions[bot] commented 5 months ago

Channel deleted.

github-actions[bot] commented 5 months ago

Test Results

   57 files  ± 0    367 suites  +2   0s :stopwatch: ±0s 1 780 tests + 7  1 780 :white_check_mark: + 7  0 :zzz: ±0  0 :x: ±0  3 095 runs  +21  3 095 :white_check_mark: +21  0 :zzz: ±0  0 :x: ±0 

Results for commit 81610a49. ± Comparison against base commit be2f7d9b.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 5 months ago

File Coverage
All files 94% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 96% :white_check_mark:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 81610a491e1cf5d4fadeb52240f32e47503db934

hcarter-775 commented 5 months ago

Completed testing using the following VDA devices on my personal v3:

  1. Virtual OnOff Switch
  2. Virtual Dimmer Switch
  3. Virtual Color Dimmer Switch
  4. Virtual Bridge with multiple instances of the devices listed above, as well as instances of various Light devices. All functionality was preserved for previously working devices, as well as for new functionality for Dimmer and Color Dimmer Switch in the cases of a Bridge and on their own.
devhari02 commented 5 months ago

Hi @hcarter-775 . Actually I need help regarding PR against smartthings drivers. It will be helpful if we connect together. Ping me through main id: hariprasad0322@gmail.com