SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
261 stars 447 forks source link

Smoke CO: Improve profile selection #1380

Closed nickolas-deboom closed 3 months ago

nickolas-deboom commented 4 months ago

The Heiman CO sensor is a new matter 1.2 device that utilizes the smoke/CO alarm subdriver. It currently matches to a profile that contains capabilities unsupported by the device - smokeDetector, relativeHumidityMeasurement, and temperatureMeasurement. This PR contains a new profile for this device as well as restructures the naming scheme of the profiles for this subdriver to be more scalable so that it will be easier to match future smoke/CO detection devices to profiles.

Note that the existing profiles will be left unchanged for now, but will be removed when drivers for matter 1.2 are released. New profiles containing the same capabilities as these existing profiles were also created, with the new naming scheme.

github-actions[bot] commented 4 months ago

Duplicate profile check: Warning - duplicate profiles detected. smoke-co-temp-humidity-comeas.yml == smoke-co-battery.yml smoke.yml == smoke-battery.yml

github-actions[bot] commented 4 months ago

Channel deleted.

github-actions[bot] commented 4 months ago

Test Results

   59 files   -  1    365 suites   - 5   0s :stopwatch: ±0s 1 726 tests  - 54  1 688 :white_check_mark:  - 54  0 :zzz: ±0  0 :x: ±0  38 :fire: ±0  3 015 runs   - 80  2 947 :white_check_mark:  - 80  0 :zzz: ±0  0 :x: ±0  68 :fire: ±0 

For more details on these errors, see this check.

Results for commit cdda5668. ± Comparison against base commit 0b1efd24.

This pull request removes 57 and adds 3 tests. Note that renamed tests count towards both. ``` Handle added lifecycle - no host user Handle added lifecycle - only regular user Handle detection frequency capability Handle doConfigure lifecycle -- e1 Handle doConfigure lifecycle -- t1 Handle occupancy attr Handle preference: autoReportType in infoChanged Handle preference: group1Sensors in infoChanged Handle preference: group1Time in infoChanged Handle preference: group2Sensors in infoChanged … ``` ``` Report from cluster 0xFC03, command 0x05 should be handled as: threeAxis(1050, -3, 9) Report from cluster 0xFC03, command 0x05 should be handled as: threeAxis(1123,-130,-24) gasDetector report should be handled ```

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 4 months ago

File Coverage
All files 58% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 38% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/PressureMeasurement/server/commands/init.lua 57% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/PressureMeasurement/types/Feature.lua 66% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/PressureMeasurement/server/attributes/MeasuredValue.lua 90% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/PressureMeasurement/server/attributes/init.lua 94% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/PressureMeasurement/init.lua 71% :x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against cdda566823f90a99ffa8df749d4d933d3b91748a