search

SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
261 stars 446 forks source link

[Aqara/K100] add OTP and notification functions #1418

Closed seojune79 closed 3 months ago

github-actions[bot] commented 3 months ago

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions[bot] commented 3 months ago

Test Results

   59 files    374 suites   0s :stopwatch: 1 807 tests 1 807 :white_check_mark: 0 :zzz: 0 :x: 3 129 runs  3 129 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 9a1693b2.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 3 months ago

File Coverage
All files 55% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/Aqara/aqara-lock/src/init.lua 53% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/Aqara/aqara-lock/src/credential_utils.lua 61% :x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 9a1693b26139d2302fc6a856502451cf37051334

Kwang-Hui commented 3 months ago

Hi team. Please refer STSE-2969 for the details.

greens commented 3 months ago

Because the LockAlarm capability is so new, it's not included in the generated code in the lua libraries release artifact. It will work on the hub itself, because that talks to the cloud.

However, for the sake of getting the tests to pass, I'd recommend including a copy of the capability with this PR.

greens commented 3 months ago

Based on local testing, some of the existing tests for the lock will also need to be updated to reflect the new functionality.