Closed RickerFicker closed 1 month ago
59 files 377 suites 0s :stopwatch: 1 819 tests 1 819 :white_check_mark: 0 :zzz: 0 :x: 3 157 runs 3 157 :white_check_mark: 0 :zzz: 0 :x:
Results for commit b738e987.
:recycle: This comment has been updated with latest results.
File | Coverage | |
---|---|---|
All files | 88% |
:x: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-window-treatment/src/aqara/aqara_utils.lua | 74% |
:x: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-window-treatment/src/aqara/init.lua | 78% |
:x: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-window-treatment/src/invert-lift-percentage/init.lua | 91% |
:white_check_mark: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-window-treatment/src/yoolax/init.lua | 94% |
:white_check_mark: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-window-treatment/src/aqara/roller-shade/init.lua | 79% |
:x: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-window-treatment/src/vimar/init.lua | 50% |
:x: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-window-treatment/src/axis/axis_version/init.lua | 97% |
:white_check_mark: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-window-treatment/src/somfy/init.lua | 91% |
:white_check_mark: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-window-treatment/src/hanssem/init.lua | 91% |
:white_check_mark: |
Minimum allowed coverage is 90%
Generated by :monkey: cobertura-action against b738e9878dc13381d83975b7e3413e6f1178f42b
Please write some tests. Added integration test cases. Please review.
Duplicate profile check: Passed - no duplicate profiles detected.
We prefer to have at least 90% code coverage via unit tests on new sub-drivers before we merge them.
Right now you don't have any coverage of
window_shade_level_cmd
,window_shade_preset_cmd
,device_added
, orrunning_direction_attr_handler
.
Added test cases for window_shade_level_cmd
, window_shade_preset_cmd
, device_added
, running_direction_attr_handler
.
Hey @greens can you please review the latest changes on this PR? Thank you.
Checking drivers/SmartThings/zigbee-window-treatment/src/screen-innovations/init.lua 1 warning
drivers/SmartThings/zigbee-window-treatment/src/screen-innovations/init.lua:150:9: (W311) value assigned to variable event is unused
Invitation URL: https://bestow-regional.api.smartthings.com/invite/QG2oOKZBRx26