SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
256 stars 445 forks source link

Matter-Switch: Integrate matter-button driver #1423

Closed nickolas-deboom closed 1 week ago

nickolas-deboom commented 2 months ago

This PR was split into three separate PRs in order to simplify reviewing and also to allow more discussion and testing before supporting combination button/switch device types.

The newly created PRs are:

github-actions[bot] commented 2 months ago

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions[bot] commented 2 months ago

Channel deleted.

github-actions[bot] commented 2 months ago

Test Results

   60 files    380 suites   0s :stopwatch: 1 824 tests 1 824 :white_check_mark: 0 :zzz: 0 :x: 3 207 runs  3 207 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 36a696d4.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 months ago

matter-button_coverage.xml

File Coverage
All files 92% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-button/src/init.lua 92% :white_check_mark:

matter-switch_coverage.xml

File Coverage
All files 96% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-button/src/init.lua 92% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 97% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91% :white_check_mark:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 36a696d41a97bd71ffb3afd8a3236e851c96737b

lelandblue commented 3 weeks ago

@nickolas-deboom - I would encourage you to add a few additional folks like Steven or Z Varberg as reviewers as they might have additional context when trying to "depreciate a driver".