SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
268 stars 454 forks source link

Add fingerprints of TOTEM Door Lock for SmartThingsEdgeDriver #1431

Closed FrankSpringfield closed 4 months ago

FrankSpringfield commented 5 months ago

The fingerprints of TOTEM Door Lock have already existed in the DTH(SmartThings Public). I tried to manage to migrate the fingerprints from DTH to Edge Driver.

Zigbee Device ID: "TOTEM H60/H90" & "TOTEM P30"

CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

lelandblue commented 5 months ago

Hello, at this time we are only accepting new fingerprint submissions as part of the WWST Works With SmartThings Program. If you work for a device company and would like your device WWST Certified please reach out to partners@smartthings.com or check out more information here.

FrankSpringfield commented 5 months ago

Hello, I'm now an intern working at SRC-N. The TOTEM fingerprints already exist in the DTH(SmartThings Public). My leader wants me to migrate the fingerprints from DTH to Edge Driver.

lelandblue commented 5 months ago

Hey @FrankSpringfield Can you provide the JIRA ticket that your working from so we can have more discussion internally?

FrankSpringfield commented 5 months ago

Hi, the JIRA ticket is here: https://smartthings.atlassian.net/browse/WWST-8009. https://smartthings.atlassian.net/browse/WWST-8010.

github-actions[bot] commented 5 months ago

Channel deleted.

github-actions[bot] commented 5 months ago

Test Results

   59 files    374 suites   0s :stopwatch: 1 807 tests 1 807 :white_check_mark: 0 :zzz: 0 :x: 3 129 runs  3 129 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 65c3d9e9.

github-actions[bot] commented 5 months ago

Test Results

   59 files    375 suites   0s :stopwatch: 1 807 tests 1 795 :white_check_mark: 0 :zzz: 0 :x: 12 :fire: 3 129 runs  3 117 :white_check_mark: 0 :zzz: 0 :x: 12 :fire:

For more details on these errors, see this check.

Results for commit d3f5b056.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 5 months ago

File Coverage
All files 94% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/yale/init.lua 81% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/configurations.lua 95% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/init.lua 94% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_utils.lua 98% :white_check_mark:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against d3f5b0563943e6cf35a4f2b056e412501c5f6b60

FrankSpringfield commented 5 months ago

Hi, @lelandblue. Considering that the 'base-lock' profile has one additional capability, 'lockCodes', compared to the 'lock-battery' profile, in this commit I have changed the deviceProfileName from 'lock-battery' to 'base-lock'. After testing, we confirmed that the TOTEM H60 can be onboarded correctly through SmartThings after updating the edge driver.