Open mh-zwave opened 2 months ago
github-actions[bot]
commented
1 month ago 60 files 377 suites 0s :stopwatch: 1 823 tests 1 823 :white_check_mark: 0 :zzz: 0 :x: 3 161 runs 3 161 :white_check_mark: 0 :zzz: 0 :x:
Results for commit 94576a37.
:recycle: This comment has been updated with latest results.
github-actions[bot]
commented
1 month ago
| File | Coverage | |
|---|---|---|
| All files | 89% |
:x: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/stelpro/init.lua | 88% |
:x: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/resideo_korea/init.lua | 81% |
:x: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/init.lua | 97% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/lux-konoz/init.lua | 91% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/zenwithin/init.lua | 94% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/leviton/init.lua | 89% |
:x: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/stelpro-ki-zigbee-thermostat/init.lua | 89% |
:x: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/popp/init.lua | 78% |
:x: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/sinope/init.lua | 92% |
:white_check_mark: |
| /home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/vimar/init.lua | 90% |
:white_check_mark: |
Minimum allowed coverage is 90%
Generated by :monkey: cobertura-action against 94576a375524f8d26f921e9325e796fb834c440a
greens
commented
1 month ago Looks like you'll also need to update the test.
I'd also suggest adding a few more. I'd suggest adding one that sets the mode. That way this error could have been detected earlier.
github-actions[bot]
commented
1 month ago Invitation URL: https://bestow-regional.api.smartthings.com/invite/QrjpZxJzOO2q
Hi Team, this one is coming from Aeotec. They are looking to make a minor fix for the /popp subdriver. This device is already WWST certified. Please let us know if there are any issues with the change they would like to make.