SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
256 stars 445 forks source link

Use component_to_endpoint to get default endpoint #1440

Closed ctowns closed 2 months ago

ctowns commented 2 months ago

Currently, the endpoint is hardcoded to the matter default endpoint (1) for some of the appliance device types. This is the default assumption for simple single component devices. However, we should use the component_to_endpoint function instead for more robust endpoint handling. In these cases, component_to_endpoint will essentially call find_default_endpoint and return the first nonzero endpoint on the matter device. In many cases it could be 1, but this change will make the endpoint handling more generic.

github-actions[bot] commented 2 months ago

Invitation URL: https://bestow-regional.api.smartthings.com/invite/kVM5pXnOyEj5

github-actions[bot] commented 2 months ago

Test Results

   59 files    374 suites   0s :stopwatch: 1 807 tests 1 807 :white_check_mark: 0 :zzz: 0 :x: 3 129 runs  3 129 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 3f6ec940.

github-actions[bot] commented 2 months ago

File Coverage
All files 56% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcRunMode/server/attributes/CurrentMode.lua 67% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcRunMode/server/attributes/SupportedModes.lua 60% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcCleanMode/server/attributes/SupportedModes.lua 60% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcCleanMode/server/attributes/CurrentMode.lua 67% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcCleanMode/types/ModeOptionStruct.lua 47% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcCleanMode/types/ModeTagStruct.lua 40% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcCleanMode/types/Feature.lua 66% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/init.lua 27% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/OperationalState/types/OperationalStateEnum.lua 69% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcCleanMode/init.lua 67% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcRunMode/client/commands/init.lua 57% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcCleanMode/client/commands/init.lua 57% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcOperationalState/server/events/init.lua 53% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcRunMode/server/commands/init.lua 57% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcRunMode/types/ModeTagStruct.lua 40% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcRunMode/types/Feature.lua 66% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcRunMode/types/ModeOptionStruct.lua 47% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcOperationalState/types/init.lua 62% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcOperationalState/types/ErrorStateStruct.lua 46% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcCleanMode/server/commands/init.lua 57% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcOperationalState/server/attributes/OperationalError.lua 62% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcOperationalState/server/attributes/OperationalState.lua 81% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcOperationalState/init.lua 71% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcOperationalState/server/commands/init.lua 57% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcRunMode/init.lua 67% :x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 3f6ec9409b124d590bbed54de3241944e76c5b04

HunsupJung commented 2 months ago

@ctowns I tested your PR and there was no problem. 👍