search

SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
256 stars 445 forks source link

changed profile name in motion.yml #1441

Open pInksenberg opened 2 months ago

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

pInksenberg commented 2 months ago

In device init lifecycle. A Matter Sensor will check and update its capabilities by running check_for_battery in init.lua. Then, device:try_update_metadata({profile = profile_name}) will be executed.

However, since there is no profile named "motion", even though the profile name in motion.yml is "matter-motion", the execution of device:try_update_metadata({profile = profile_name}) will fail.

pInksenberg commented 2 months ago

hello @greens , can you help us with verification?

pInksenberg commented 3 days ago

hello @ctowns , cloud you plz help to review?

ctowns commented 2 days ago

Hello @pInksenberg! Before we make this change, we must confirm that the profile with the name matter-motion is not currently being used by devices, or else changing the name could result in some devices losing their profile presentation.

@hcarter-775 is working on a similar change to clean up the profile names here: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/1466

I believe he has confirmed we can safely make this change, so we will incorporate this as a part of #1466