search

SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
256 stars 445 forks source link

Matter-Window-Covering: Add test cases for shade status issue #1442

Closed nickolas-deboom closed 2 months ago

nickolas-deboom commented 2 months ago

This change adds test cases to verify the fix for an issue where the window covering operational status is not updated from "Opening" or "Closing" to "Partially Open" after the shade level is adjusted in the ST app.

github-actions[bot] commented 2 months ago

Channel deleted.

github-actions[bot] commented 2 months ago

Test Results

   59 files  ±0    375 suites  ±0   0s :stopwatch: ±0s 1 809 tests +2  1 797 :white_check_mark: +2  0 :zzz: ±0  0 :x: ±0  12 :fire: ±0  3 131 runs  +2  3 119 :white_check_mark: +2  0 :zzz: ±0  0 :x: ±0  12 :fire: ±0 

For more details on these errors, see this check.

Results for commit fed78f87. ± Comparison against base commit a319a236.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 months ago

File Coverage
All files 95% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-window-covering/src/init.lua 95% :white_check_mark:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against fed78f87e52de5c80448f25498e9b3d4da37a656

tpmanley commented 2 months ago

Can you add a unit test that would catch this issue?

nickolas-deboom commented 2 months ago

Can you add a unit test that would catch this issue?

I added 2 test cases in the latest commit: the first adjusts the shade level by > 2%, which passes on both the main branch and with these changes. The second adjusts the shade level by 2%, which on the main branch does not update the capability to Partially Open.

nickolas-deboom commented 2 months ago

A similar fix to this issue was made by this PR. I think that that solution is more complete, as it includes an update to current_status_handler that I believe is needed. I think that I will revert my driver changes, but I think it would still a good idea to keep the test cases updates made in this PR, or possibly include them in PR 1447.

Edit: The driver changes in this PR have been reverted, and the test cases will be merged into fix/matter-window-covering, which is now the target branch for this PR.