search

SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
251 stars 442 forks source link

Add device configuration for supporting Routine #1458

Open HunsupJung opened 3 weeks ago

HunsupJung commented 3 weeks ago

In the case of mode capability, presentation is implemented in the list display type. Therefore, device configuration was added to support automation in the device type that supports the mode capability.

github-actions[bot] commented 3 weeks ago

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions[bot] commented 3 weeks ago

Invitation URL: https://bestow-regional.api.smartthings.com/invite/QG2o1GbrXmj6

github-actions[bot] commented 3 weeks ago

Test Results

   59 files    375 suites   0s :stopwatch: 1 808 tests 1 808 :white_check_mark: 0 :zzz: 0 :x: 3 135 runs  3 135 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 850e7712.

github-actions[bot] commented 3 weeks ago

File Coverage
All files 55% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcRunMode/client/commands/init.lua 57% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcOperationalState/init.lua 71% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcCleanMode/server/attributes/SupportedModes.lua 60% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcCleanMode/server/attributes/CurrentMode.lua 67% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcRunMode/types/ModeOptionStruct.lua 47% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcRunMode/types/ModeTagStruct.lua 40% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcRunMode/types/Feature.lua 66% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/OperationalState/types/OperationalStateEnum.lua 69% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcOperationalState/server/events/init.lua 53% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcOperationalState/server/commands/init.lua 57% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcCleanMode/types/ModeOptionStruct.lua 47% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcCleanMode/types/ModeTagStruct.lua 40% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcCleanMode/types/Feature.lua 66% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcRunMode/server/commands/init.lua 57% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcOperationalState/server/attributes/OperationalState.lua 81% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcOperationalState/server/attributes/OperationalError.lua 62% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcCleanMode/client/commands/init.lua 57% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcRunMode/server/attributes/SupportedModes.lua 60% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcRunMode/server/attributes/CurrentMode.lua 67% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcOperationalState/types/ErrorStateStruct.lua 46% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcOperationalState/types/init.lua 62% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcCleanMode/init.lua 67% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/init.lua 27% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcCleanMode/server/commands/init.lua 57% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-rvc/src/RvcRunMode/init.lua 67% :x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 850e77121b52a8df3d5f2dc0a0d8650d52470b51

ctowns commented 2 weeks ago

Is metadata the only way we can support supportedArguments for now? Longterm, could we modify the plugin to utilize the supportedArguments value for R3 so we do not need custom metadata? I think this is okay but in general I think we try to avoid using metadata with custom presentations.

HunsupJung commented 2 weeks ago

Yes, the metadata is the only way to support supportedArguments for now. I will ask Plugin team to apply supportedArguments to mode capability. (Actually, It also needs to apply dynamic list to mode capability). But I'm not sure how long does it take that Plugin team applies my request.

I think this is okay but in general I think we try to avoid using metadata with custom presentations.

I agree with you