Open HunsupJung opened 3 weeks ago
Duplicate profile check: Passed - no duplicate profiles detected.
Channel deleted.
59 files 375 suites 0s :stopwatch: 1 808 tests 1 808 :white_check_mark: 0 :zzz: 0 :x: 3 135 runs 3 135 :white_check_mark: 0 :zzz: 0 :x:
Results for commit ba3a5d30.
File | Coverage | |
---|---|---|
All files | 76% |
:x: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/ActivatedCarbonFilterMonitoring/types/ChangeIndicationEnum.lua | 75% |
:x: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/ActivatedCarbonFilterMonitoring/types/Feature.lua | 57% |
:x: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/HepaFilterMonitoring/server/attributes/Condition.lua | 67% |
:x: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/HepaFilterMonitoring/server/attributes/ChangeIndication.lua | 78% |
:x: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/HepaFilterMonitoring/types/Feature.lua | 57% |
:x: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/HepaFilterMonitoring/types/ChangeIndicationEnum.lua | 75% |
:x: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/ActivatedCarbonFilterMonitoring/server/attributes/Condition.lua | 67% |
:x: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/ActivatedCarbonFilterMonitoring/server/attributes/ChangeIndication.lua | 78% |
:x: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua | 80% |
:x: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/ActivatedCarbonFilterMonitoring/init.lua | 71% |
:x: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/HepaFilterMonitoring/init.lua | 71% |
:x: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua | 71% |
:x: |
Minimum allowed coverage is 90%
Generated by :monkey: cobertura-action against ba3a5d30ad85337a2727b0852fa0c0b4d870b99b
I believe this will solve the issue in the future when we can use this: https://github.ecodesamsung.com/iot/SmartThingsCapabilities/pull/351
@HunsupJung could we wait for the new capability to use here, or do we need to make this change now?
We can use Fan Mode capability that you made. Thank you 👍
@ctowns When should we change the airConditionFanMode to the newly created Fan Mode capability?
@ctowns Can we use this PR until creating new Fan Mode capability?
The matter-fan driver uses airCondtionerFanMode and its label is "Air Condtioner Fan Mode". This is for changing a label to "Fan Mode" from "Air Conditioner Fan Mode"