Closed dljsjr closed 2 weeks ago
59 files 376 suites 0s :stopwatch: 1 808 tests 1 808 :white_check_mark: 0 :zzz: 0 :x: 3 143 runs 3 143 :white_check_mark: 0 :zzz: 0 :x:
Results for commit 856fd1ee.
:recycle: This comment has been updated with latest results.
Minimum allowed coverage is 90%
Generated by :monkey: cobertura-action against 856fd1ee311474e2464d3f16504a32bc01619c00
I approved, but actually I think we may want to move the spec
and other folders under the test
folder as that will by default be excluded from the archives that get uploaded. But let me verify that.
Yeah, test or tests directory would have the not uploaded and thus not pushed to everyones hub: https://github.com/SmartThingsCommunity/smartthings-cli/blob/0ebd3c72c819fd3681746c4b01740038a7ede910/packages/edge/src/commands/edge/drivers/package.ts#L136
Yeah, test or tests directory would have the not uploaded and thus not pushed to everyones hub: SmartThingsCommunity/smartthings-cli@
0ebd3c7
/packages/edge/src/commands/edge/drivers/package.ts#L136
Done. I also added a script in the driver root for running the specs.
Channel deleted.
We don't run Busted tests in CI, but the Hue driver is now very testable after the recent refactor. The ability to write integration tests for LAN Drivers is still forthcoming, but we're also going to be accumulating unit tests for Hue going forward as well.
We keep the
spec
folder as a sibling to thesrc
folder so that it doesn't get included in the driver package, so care should be taken when setting up the LUA PATH to run these tests.We also fix a bug that was reported by some community users, the presence of which was validated by and is also now covered by the new specs.
For Reviewers
The PR is broken up in to two commits. The first commits are all of the new Busted work. The second commit is the bugfix.