search

SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
251 stars 442 forks source link

Matter Pump: add missing embedded cluster include #1483

Closed ctowns closed 2 weeks ago

ctowns commented 2 weeks ago

This was accidentally missed in the initial commit. This adds the include for the embedded cluster defs in the situation that the hub is running older lua libs (api version < 10)

ctowns commented 2 weeks ago

Tested this and confirmed all values are working on a hub with 53 FW running v52 api 9 lua libs (which don't include the pump cluster definitions).

Retested and confirmed functionality as outlined here: https://smartthings.atlassian.net/wiki/spaces/~62de3b63b6b0b70770d7905d/pages/3238854850/Matter+1.2+VDA+Testing+with+Driver+Clusters

github-actions[bot] commented 2 weeks ago

Channel deleted.

github-actions[bot] commented 2 weeks ago

Test Results

   60 files    377 suites   0s :stopwatch: 1 819 tests 1 819 :white_check_mark: 0 :zzz: 0 :x: 3 157 runs  3 157 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 4fb39cb5.

github-actions[bot] commented 2 weeks ago

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 4fb39cb595f4916b36c585f41d8429b46c8c664b