SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
251 stars 442 forks source link

Revert matter lock changes and move aqara to sub driver #1495

Closed ctowns closed 1 week ago

ctowns commented 1 week ago

This reverts the following changes: d8209c444415563c0b15cb3512bcf24960707a85 and fdefdb706056c0fa5379f5fe74ed926fdbabac55 which were a part of #1413

The aqara lock has now been moved to a sub driver and the base matter-lock functionality has been restored.

github-actions[bot] commented 1 week ago

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions[bot] commented 1 week ago

Channel deleted.

github-actions[bot] commented 1 week ago

Test Results

   60 files  ±0    377 suites  ±0   0s :stopwatch: ±0s 1 821 tests ±0  1 821 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  3 159 runs  ±0  3 159 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 7c2a912b. ± Comparison against base commit d79b2abd.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 week ago

File Coverage
All files 93% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 92% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 97% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/aqara-lock/init.lua 96% :white_check_mark:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 7c2a912bb82a0df160e17df5781c62fc3743a4b4

Con-Tejus commented 1 week ago

Sorry I don't know if I missed it during out call, but would we want to also include the fix in recovering already effected devices by adding the read operation for RequirePINForRemoteOperation within the device_init call for the base matter lock driver?

ctowns commented 1 week ago

Sorry I don't know if I missed it during out call, but would we want to also include the fix in recovering already effected devices by adding the read operation for RequirePINForRemoteOperation within the device_init call for the base matter lock driver?

Just added this! Let's start testing with Jeff and the VDA so we can verify the changes still work as expected for already joined devices.