SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
259 stars 446 forks source link

Merge Switch and Button Drivers #1547

Closed nickolas-deboom closed 5 days ago

nickolas-deboom commented 1 month ago

Type of Change

Checklist

Description of Change

This PR addresses CHAD-13270 to integrate the functionality from matter-button into the matter-switch driver, so that we can deprecate the matter-button driver.

Note that these changes were originally located in PR 1423, but that PR was split into multiple PRs in order to simplify the amount of changes. This PR only includes support for pure-button and pure-switch devices. Once more discussion has been had on how combination button-switch devices should be configured, PR 1596 will be updated to include support for these combination devices.

Summary of Completed Tests

Testing was performed on several switch and button devices as documented here: https://smartthings.atlassian.net/wiki/spaces/CHIP/pages/3340304693/Matter-Switch+Matter-Button+Integration+Testing+Status

github-actions[bot] commented 1 month ago

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions[bot] commented 1 month ago

Test Results

   61 files    381 suites   0s :stopwatch: 1 855 tests 1 855 :white_check_mark: 0 :zzz: 0 :x: 3 241 runs  3 241 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 0fbb9bc6.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 month ago

matter-button_coverage.xml

File Coverage
All files 92% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-button/src/init.lua 92% :white_check_mark:

matter-switch_coverage.xml

File Coverage
All files 96% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-button/src/init.lua 92% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 97% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91% :white_check_mark:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 0fbb9bc6083040f190468884939c0a4057747a8f

github-actions[bot] commented 1 month ago

Channel deleted.

nickolas-deboom commented 6 days ago

I left a few more small comments but this is my final review and I think it's ready. Has this also been regression tested with some of the switch/button devices on the VDA? For example, confirming a light, button, and composed bridged devices work would be a good test.

I tested several virtual switch devices as well as a composed bridge device with the VDA and everything is functioning as expected. The Generic Switch virtual device does not onboard properly so I tested the button functionality with an IKEA remote, which functioned as expected as well.