Closed nickolas-deboom closed 2 weeks ago
Duplicate profile check: Passed - no duplicate profiles detected.
61 files ±0 379 suites +2 0s :stopwatch: ±0s 1 826 tests +5 1 826 :white_check_mark: +5 0 :zzz: ±0 0 :x: ±0 3 207 runs +7 3 207 :white_check_mark: +7 0 :zzz: ±0 0 :x: ±0
Results for commit ccd86f09. ± Comparison against base commit 1845be8b.
:recycle: This comment has been updated with latest results.
File | Coverage | |
---|---|---|
All files | 95% |
:white_check_mark: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua | 91% |
:white_check_mark: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua | 96% |
:white_check_mark: |
Minimum allowed coverage is 90%
Generated by :monkey: cobertura-action against ccd86f09ce2391e38ef0b62a87908ed06886130a
It looks like this PR has 2 commits, one of which (5e98aad) seems to already be included in https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/1547
Could you rebase and remove the first commit to reduce the changeset for this PR?
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
6 out of 7 committers have signed the CLA.
:white_check_mark: nickolas-deboom
:white_check_mark: cjswedes
:white_check_mark: tpmanley
:white_check_mark: lelandblue
:white_check_mark: hcarter-775
:white_check_mark: ctowns
:x: satyajitanand
You have signed the CLA already but the status is still pending? Let us recheck it.
It looks like this PR has 2 commits, one of which (5e98aad) seems to already be included in #1547
Could you rebase and remove the first commit to reduce the changeset for this PR?
I was having some issues with rebasing and decided to just create a new PR and close this one, because there were also some changes from PR 1548 that I was trying to bring in.
Type of Change
Checklist
Description of Change
This PR adds support for combination button/switch device types that are now being released. These changes were prompted by new Inovelli devices that feature button and switch functionality. Note that some additional discussion is needed on how these devices should be configured before this PR can move forward. Also note that these changes rely on PR 1547 and PR 1548.
Summary of Completed Tests