SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
259 stars 446 forks source link

Add datastore:commit() calls around API key operations #1553

Closed dljsjr closed 1 month ago

dljsjr commented 1 month ago

Check all that apply

Type of Change

Checklist

Description of Change

This change calls datastore:commit() every time a Hue Bridge API key is captured/modified/removed. This is an API that's gated behind a SmartThings controlled allowlist, so it will not currently work until the Hue driver has been added to the allowlist. But I have tested that it does not cause a crash or issues with the driver's operation in any way, so the change is safe.

Summary of Completed Tests

Real device developer testing has been performed.

github-actions[bot] commented 1 month ago

Channel deleted.

github-actions[bot] commented 1 month ago

Test Results

   60 files    375 suites   0s :stopwatch: 1 820 tests 1 820 :white_check_mark: 0 :zzz: 0 :x: 3 169 runs  3 169 :white_check_mark: 0 :zzz: 0 :x:

Results for commit d93ddb0c.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 month ago

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against d93ddb0c7b6a5dbad02f3a4fcb814909306353cd