SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
269 stars 462 forks source link

Create a series of optional profiles for room ac #1554

Closed hcarter-775 closed 3 months ago

hcarter-775 commented 3 months ago

Edit configure logic to permit a wider array of room ac profiles. Further, I have added several new profiles that can be mapped to.

Check all that apply

Type of Change

Checklist

Description of Change

Summary of Completed Tests

github-actions[bot] commented 3 months ago

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions[bot] commented 3 months ago

Test Results

   60 files    375 suites   0s :stopwatch: 1 821 tests 1 821 :white_check_mark: 0 :zzz: 0 :x: 3 170 runs  3 170 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 31ceea8e.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 3 months ago

File Coverage
All files 80% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 83% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 42% :x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 31ceea8ef3dd2966a316db81d580b7ea4510c954

ctowns commented 3 months ago

This needs to be regression tested against the room AC device in the Matter VDA

github-actions[bot] commented 3 months ago

Channel deleted.

hcarter-775 commented 3 months ago

This needs to be regression tested against the room AC device in the Matter VDA

This has been done. The new configure logic leads to the same functionality as in the main branch.