SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0

259 stars 446 forks source link

New Device (Matter Lock) Aqara U300 #1557

Closed lelandblue closed 2 weeks ago

lelandblue commented 1 month ago

Check all that apply

Type of Change

[ X ] WWST Certification Request
[ ] Bug fix
[ ] New feature
[ ] Refactor

Checklist

[ X ] I have performed a self-review of my code
[ ] I have commented my code in hard-to-understand areas
[ ] I have verified my changes by testing with a device or have communicated a plan for testing
[ ] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

This PR is a fingerprint only code change to add a fingerprint for the Aqara U300 device. I anticipate that this will use the new sub-driver created for the U200 device.

Summary of Completed Tests

The testing of this device certification will be handled by the WWST process.

github-actions[bot] commented 1 month ago

Channel deleted.

github-actions[bot] commented 1 month ago

Test Results

60 files 375 suites 0s :stopwatch: 1 820 tests 1 820 :white_check_mark: 0 :zzz: 0 :x: 3 169 runs 3 169 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 19177ead.

github-actions[bot] commented 1 month ago

Test Results

61 files 375 suites 0s :stopwatch: 1 823 tests 1 823 :white_check_mark: 0 :zzz: 0 :x: 3 171 runs 3 171 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 728b21af.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 month ago

File	Coverage
All files	`93%`	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/aqara-lock/init.lua	`96%`	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua	`92%`	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua	`97%`	:white_check_mark:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 728b21afc4f90cd0f0e776a82d52f93177802d00

HunsupJung commented 3 weeks ago

I missed that we need to update the function which is checking the aqara U300 product. The function have to return true when product id is 0x2801(U300).

lelandblue commented 3 weeks ago

@hcarter-775 or @nickolas-deboom Please re-review the latest changes when you have a moment.