SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
269 stars 462 forks source link

Matter Bridge Aqara Cube Support with Custom Capability #1572

Closed DongHoon-Ryu closed 3 months ago

DongHoon-Ryu commented 3 months ago

Currently, the Generic EdgeDriver applied to the Matter Bridge Aqara Cube is implemented by mapping six faces into individual components, making it difficult to check the event occurrence of individual faces on one screen.

Check all that apply

Type of Change

Checklist

Description of Change

This commit wants to improve the problem by mapping the event from Matter Bridge with Aqara Cube Custom Capability developed by Zigbee driver. This means that there is a limitation that the Action Event of the Cube that the Matter Bridge does not give can not be processed.

Summary of Completed Tests

github-actions[bot] commented 3 months ago

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions[bot] commented 3 months ago

Invitation URL: https://bestow-regional.api.smartthings.com/invite/RPMxxeddkVMm

github-actions[bot] commented 3 months ago

Test Results

   61 files    375 suites   0s :stopwatch: 1 821 tests 1 821 :white_check_mark: 0 :zzz: 0 :x: 3 170 runs  3 170 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 03f29544.

github-actions[bot] commented 3 months ago

File Coverage
All files 74% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-button/src/init.lua 74% :x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 03f295448d48dc5f2acfcd69c21c6b526417643c

DongHoon-Ryu commented 3 months ago

Dear All, About test coverage, is it possible to test events that support custom capability not described in lua_libs?