Closed hcarter-775 closed 1 week ago
Duplicate profile check: Warning - duplicate profiles detected. fan-wind.yml == fan.yml
61 files 378 suites 0s :stopwatch: 1 851 tests 1 851 :white_check_mark: 0 :zzz: 0 :x: 3 207 runs 3 207 :white_check_mark: 0 :zzz: 0 :x:
Results for commit 95526a7b.
:recycle: This comment has been updated with latest results.
File | Coverage | |
---|---|---|
All files | 81% |
:x: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua | 83% |
:x: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua | 42% |
:x: |
Minimum allowed coverage is 90%
Generated by :monkey: cobertura-action against 95526a7b75f8b9356fb2c890380195433350dc88
Channel deleted.
Check all that apply
Type of Change
Checklist
Description of Change
Originally a 1.3 addition, seen here: CHAD-13561 but was mentioned in this ticket: CHAD-13781
and was pushed ahead of the 1.3 launch, since it is not directly related to the 1.3 launch.
Functionality has been added to matter thermostat to support FanControl's Rock feature using the fanOscillationMode capability.
Further, a series of new profiles were built to support this feature. They are the same as previously made air purifier profiles, with the addition of the rocking capability.
Implementation is almost identical to what was built for FanControl's Wind feature support.
New:
Summary of Completed Tests