SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
259 stars 446 forks source link

Matter Sensor: return nil if no unit conversion is possible #1582

Open ctowns opened 3 weeks ago

ctowns commented 3 weeks ago

Check all that apply

Type of Change

Checklist

Description of Change

Summary of Completed Tests

github-actions[bot] commented 3 weeks ago

Invitation URL: https://bestow-regional.api.smartthings.com/invite/Boj0zD73vn2A

github-actions[bot] commented 3 weeks ago

File Coverage
All files 87% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/smoke-co-alarm/init.lua 83% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 91% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua 92% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/embedded-cluster-utils.lua 42% :x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 602bced7425981a5551e35879da067bf0545b606

github-actions[bot] commented 3 weeks ago

Test Results

   61 files  ±0    375 suites  ±0   0s :stopwatch: ±0s 1 822 tests +1  1 822 :white_check_mark: +1  0 :zzz: ±0  0 :x: ±0  3 170 runs  +1  3 170 :white_check_mark: +1  0 :zzz: ±0  0 :x: ±0 

Results for commit 602bced7. ± Comparison against base commit 2125c846.

:recycle: This comment has been updated with latest results.

nickolas-deboom commented 6 days ago

LGTM!