Closed ctowns closed 3 weeks ago
61 files ±0 375 suites ±0 0s :stopwatch: ±0s 1 822 tests +1 1 822 :white_check_mark: +1 0 :zzz: ±0 0 :x: ±0 3 170 runs +1 3 170 :white_check_mark: +1 0 :zzz: ±0 0 :x: ±0
Results for commit bd532530. ± Comparison against base commit 2125c846.
:recycle: This comment has been updated with latest results.
File | Coverage | |
---|---|---|
All files | 94% |
:white_check_mark: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua | 95% |
:white_check_mark: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua | 91% |
:white_check_mark: |
Minimum allowed coverage is 90%
Generated by :monkey: cobertura-action against bd532530cbf3c8a05684639c90f1bf10d1796e81
Invitation URL: https://bestow-regional.api.smartthings.com/invite/r3MymNzVBZMp
Check all that apply
Type of Change
Checklist
Description of Change
CHAD-13811 Add the ability to override the child profile that would be assigned based on the child's device type. This is done because some devices have the "On/Off Plug" device type, but it would make more sense for them to appear with the switch icon as indicated in their WWST fingerprint.
Summary of Completed Tests
[x] Unit test added A unit test has been added to test this behavior.
[x] Tested on device (Sonoff 3-Key Switch) Additionally, testing was done with the Sonoff 3-key switch, which is a device that would need a child profile override to show up correctly. This is because the child devices have the "On Off Plug" device type (which is correct in this case), but it would make more sense for this device to appear with our
switch
icon rather than ourplug
icon. The parent device will already show as aswitch
because that is the profile that is used in the fingerprint for the parent device. Therefore, we needed this override so that the child and parent devices show up with the same icon (switch instead of plug). This change was tested with this device and now parent and child devices show up correctly.[x] Test on VDA Tested with composed light device on VDA to confirm there was no regression in existing functionality. The mutli-light device type still appears correctly with the child devices being assigned to the expected profiles.