SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
259 stars 446 forks source link

fix an issue of sonoff 3 key switch icon inconsistency #1584

Closed pInksenberg closed 3 weeks ago

pInksenberg commented 3 weeks ago

We found a problem with the driver icon display inconsistency in the Sonoff 3-key switch (vid 0x1321 and pid 0x000D, which has passed WWST). The main key displays the "switch" icon, while the other two child keys show the "plug" icon, leading to inconsistency.

The root cause is that the fingerprint match to a "switch-binary" profile for the main key according to vid and pid, while others child-key re-match a "plug-binary" profile according to the function "assign_child_profile" during driver init.

We add an if "statement" to check the device's vid and pid, and then we assign the consistency icon to the device as it was first designated.

Check all that apply

Type of Change

Checklist

Description of Change

Summary of Completed Tests

github-actions[bot] commented 3 weeks ago

Channel deleted.

github-actions[bot] commented 3 weeks ago

Test Results

   61 files  ±0    375 suites  ±0   0s :stopwatch: ±0s 1 821 tests ±0  1 821 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0  3 169 runs  ±0  3 169 :white_check_mark: ±0  0 :zzz: ±0  0 :x: ±0 

Results for commit 3cb7f0fa. ± Comparison against base commit 2125c846.

github-actions[bot] commented 3 weeks ago

File Coverage
All files 94% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 95% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91% :white_check_mark:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 3cb7f0fa0661257edcaf0cae2002bd2eb9e66cb0