SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
269 stars 463 forks source link

fix an issue of fan proposed capabilities #1593

Closed pInksenberg closed 1 month ago

pInksenberg commented 3 months ago

Description: During the WWST for the Yeelight fan (a bridged device), we discovered that after onboarding the devices by sharing through yeelight App, it displays an unsupported capability called "windMode."

The reason is that the "fan.yml" profile is chosen for the bridged device (fan device type) when it is shared via Matter, and the windMode capability is included by default in this profile. However, certain fan device types do not support windMode because the WindSetting (0x000A) is not a mandatory attribute, which means that the command to write the WindSetting cannot be sent.

Type of Change

Checklist

Description of Change

Summary of Completed Tests

github-actions[bot] commented 3 months ago

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions[bot] commented 3 months ago

Invitation URL: https://bestow-regional.api.smartthings.com/invite/8zM7y1yEvXlp

github-actions[bot] commented 3 months ago

Test Results

   61 files    375 suites   0s :stopwatch: 1 823 tests 1 787 :white_check_mark: 0 :zzz: 0 :x: 36 :fire: 3 171 runs  3 108 :white_check_mark: 0 :zzz: 0 :x: 63 :fire:

For more details on these errors, see this check.

Results for commit bea6d14f.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 3 months ago

File Coverage
All files 58% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 42% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 59% :x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against bea6d14f01d0e0801570e92b89afcdd8977e612d

hcarter-775 commented 3 months ago

Hello, the problems mentioned in this PR are being handled in a wider scale in this PR here. Unfortunately, the metadata used in the original fan profile cannot be used for the proposed new profiles, and this work to create new metadata can be tracked here. These changes will go live as soon as the metadata is released in production OR when the new fanMode capability is released to production at the end of R3, whichever happens first. If you have any questions, feel free to reach out! Thank you

wangjinliang12345 commented 3 months ago

@hcarter-775 I have assigned https://smartthings.atlassian.net/jira/software/c/projects/MTR/issues/MTR-778 to you, please notify us when this is ready and we will test here.

hcarter-775 commented 2 months ago

Hello @wangjinliang12345 , the fixes to this should now be in production. Please re-test at your convenience!