SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
269 stars 463 forks source link

Matter Sensor: Streamline do_configure function in air quality sensor subdriver #1594

Closed hcarter-775 closed 1 month ago

hcarter-775 commented 3 months ago

Check all that apply

Type of Change

Checklist

Description of Change

Refactor the air quality sensor configure logic for readability and clarity.

Summary of Completed Tests

Unit test added and old unit tests continue to pass. Tested with the VDA air quality sensor as well.

github-actions[bot] commented 3 months ago

Channel deleted.

github-actions[bot] commented 3 months ago

Test Results

   63 files    396 suites   0s :stopwatch: 1 937 tests 1 937 :white_check_mark: 0 :zzz: 0 :x: 3 361 runs  3 361 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 3f32d987.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 3 months ago

File Coverage
All files 88% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/embedded-cluster-utils.lua 42% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua 92% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 92% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/smoke-co-alarm/init.lua 83% :x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 3f32d9870692f4d359cfc1435df2dd4bb92e082e