SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0

269 stars 462 forks source link

matter-lock: Expose 'not fully locked' when reported by the lock #1595

Closed tpmanley closed 3 months ago

tpmanley commented 3 months ago

Previously we were mapping the 'not fully locked' to 'unknown' but now that the lock attribute has the 'not fully locked' variant we can expose that directly.

https://smartthings.atlassian.net/browse/CHAD-11259

Type of Change

[ ] Bug fix
[X] New feature
[ ] Refactor

Checklist

[X] I have performed a self-review of my code
[X] I have commented my code in hard-to-understand areas
[X] I have verified my changes by testing with a device or have communicated a plan for testing

Summary of Completed Tests

Tested with a Yale Matter lock

github-actions[bot] commented 3 months ago

Channel deleted.

github-actions[bot] commented 3 months ago

Test Results

61 files 375 suites 0s :stopwatch: 1 827 tests 1 827 :white_check_mark: 0 :zzz: 0 :x: 3 177 runs 3 177 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 1caa6571.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 3 months ago

File	Coverage
All files	`93%`	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua	`97%`	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua	`92%`	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/aqara-lock/init.lua	`96%`	:white_check_mark:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 1caa6571925061a3dbee1a3f43972dda193952bb

tpmanley commented 3 months ago

Could you add the same https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/blob/main/drivers/SmartThings/matter-lock/src/aqara-lock/init.lua#L60 also?

Done