SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0

269 stars 462 forks source link

matter-lock: Add 'not fully locked' to the embedded device config #1602

Closed tpmanley closed 2 months ago

tpmanley commented 3 months ago

Without this change the 'not fully locked' was being displayed but without the correct translations.

https://smartthings.atlassian.net/browse/CHAD-11259

Type of Change

[ ] WWST Certification Request
[X] Bug fix
[ ] New feature
[ ] Refactor

Checklist

[X] I have performed a self-review of my code
[X] I have commented my code in hard-to-understand areas
[X] I have verified my changes by testing with a device or have communicated a plan for testing
[ ] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Summary of Completed Tests

Tested with a Yale lock

github-actions[bot] commented 3 months ago

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions[bot] commented 3 months ago

Channel deleted.

github-actions[bot] commented 3 months ago

Test Results

61 files 375 suites 0s :stopwatch: 1 827 tests 1 827 :white_check_mark: 0 :zzz: 0 :x: 3 177 runs 3 177 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 9b3084ee.

github-actions[bot] commented 3 months ago

File	Coverage
All files	`93%`	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua	`92%`	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua	`97%`	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/aqara-lock/init.lua	`96%`	:white_check_mark:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 9b3084ee63d7ceacb5de30e32e90e78c71d6df80

tpmanley commented 2 months ago

This is currently set to be merged to the beta branch. I think this should be merged to main first and then cherry-picked to beta as needed if we choose to expedite it

I did it this way because I want it to go to beta since the change to start creating not fully locked events is already in beta. After merging I would merge beta back down to main.

tpmanley commented 2 months ago

Also, can you help me understand how this affects the translation used?

@ctowns the enabledValues in the embedded device config drive the alternatives in the presentation and those are what are used to find the translations. When not fully locked was missing from enabledValues it was also not added to alternatives so the value was directly displayed instead of the translation.