Matter Thermostat and Sensor: Reimplement dynamic constraints

[nickolas-deboom]

Type of Change

• [ ] WWST Certification Request
  • If this is your first time contributing code:
    • [ ] I have reviewed the README.md file
    • [ ] I have reviewed the CODE_OF_CONDUCT.md file
    • [ ] I have signed the CLA
  • [ ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
• [ ] Bug fix
• [x] New feature
• [ ] Refactor

Checklist

• [x] I have performed a self-review of my code
• [x] I have commented my code in hard-to-understand areas
• [x] I have verified my changes by testing with a device or have communicated a plan for testing
• [x] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Re-implement dynamic numeric constraints for matter-thermostat and matter-sensor, which needed to be removed from the drivers until temperature conversion was fixed for the setpoint ranges in hubcore 54.

Note that this change undoes the changes made by PR 1455.

CHAD-12993 CHAD-12994

Summary of Completed Tests

See here for an overview of testing for this change.

[github-actions[bot]]

Invitation URL: https://bestow-regional.api.smartthings.com/invite/QG2owgapNE26

[github-actions[bot]]

Test Results

   62 files    383 suites   0s :stopwatch: 1 862 tests 1 862 :white_check_mark: 0 :zzz: 0 :x: 3 249 runs  3 249 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 2e9f42ab.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

matter-sensor_coverage.xml

File	Coverage
All files	86%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/embedded-cluster-utils.lua	42%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua	91%	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/smoke-co-alarm/init.lua	83%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua	91%	:white_check_mark:

matter-thermostat_coverage.xml

File	Coverage
All files	81%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/embedded-cluster-utils.lua	42%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua	91%	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/smoke-co-alarm/init.lua	83%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua	91%	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua	83%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua	42%	:x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 2e9f42ab0351232a77f84cf3c7f485af3fca03d6

[nickolas-deboom]

@nickolas-deboom have you done regression testing against FW53 to confirm these values are not emitted on hubs running older FW?

I did a test with a hub on FW 53 with lua libs api version 10 and ensured that the capabilities were note emitted. See here for a small writeup of this test.