SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
269 stars 463 forks source link

Sort endpoints before initializing switch #1657

Closed nickolas-deboom closed 2 months ago

nickolas-deboom commented 2 months ago

Type of Change

Checklist

Description of Change

PR 1547 introduced a minor regression where the device endpoints are not being sorted before creating child devices. This is causing labels for child devices to be incorrect in some cases, as in MTR-828.

Summary of Completed Tests

A new test case was added to verify that child devices are created in order of their endpoints. The child devices listed in the mock device are in a different order than their endpoints sequentially, but they are created in the correct order. This test case fails without this change.

github-actions[bot] commented 2 months ago

Test Results

   63 files    395 suites   0s :stopwatch: 1 934 tests 1 934 :white_check_mark: 0 :zzz: 0 :x: 3 358 runs  3 358 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 05d328d5.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 2 months ago

File Coverage
All files 93% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded-cluster-utils.lua 38% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 96% :white_check_mark:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 05d328d5b2c7d644cdfe339c85da8564d54b2c85

github-actions[bot] commented 2 months ago

Channel deleted.