SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
269 stars 462 forks source link

Implement Flow Sensor device type #1665

Open nickolas-deboom opened 1 month ago

nickolas-deboom commented 1 month ago

Type of Change

Checklist

Description of Change

CHAD-13850

This change adds support for the Flow Sensor device type. This device type was added to matter spec a while ago but has not been implemented into our platform yet.

This PR shouldn't be merged until the tickets listed on this page are complete.

Summary of Completed Tests

New unit tests were implemented to verify the cluster -> capability mappings. Note that there are not any existing matter flow sensors yet, and there is not a virtual flow sensor device in the VDA, so we can't test this on a real device at this time.

github-actions[bot] commented 1 month ago

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions[bot] commented 1 month ago

Test Results

   63 files    397 suites   0s :stopwatch: 1 937 tests 1 937 :white_check_mark: 0 :zzz: 0 :x: 3 361 runs  3 361 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 48b7a8a2.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 month ago

File Coverage
All files 86% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua 92% :white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/embedded-cluster-utils.lua 42% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 88% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/smoke-co-alarm/init.lua 83% :x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 48b7a8a2408fd46bee7ffd54ed91848f22b952df

hcarter-775 commented 1 month ago

we need a fingerprint for the device :+1:

nickolas-deboom commented 1 month ago

we need a fingerprint for the device 👍

I forgot to respond but I added one!