IOTE-4566 Limit temperature setpoint ranges

[nickolas-deboom]

Type of Change

• [ ] WWST Certification Request
  • If this is your first time contributing code:
    • [ ] I have reviewed the README.md file
    • [ ] I have reviewed the CODE_OF_CONDUCT.md file
    • [ ] I have signed the CLA
  • [ ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
• [x] Bug fix
• [ ] New feature
• [ ] Refactor

Checklist

• [x] I have performed a self-review of my code
• [x] I have commented my code in hard-to-understand areas
• [x] I have verified my changes by testing with a device or have communicated a plan for testing
• [x] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

IOTE-4566

Clamp the min and max values of temperature setpoint capabilities so that the ranges of deg C and deg F don't overlap. This is currently being done for the oven device type and now should be extended to other devices types using the temperatureSetpoint, thermostatHeatingSetpoint, or thermostatCoolingSetpoint capabilities (or the associated Setpoint Range capabilities). These changes are necessary because the driver is not aware of the temperature unit when a setpoint value is updated via a capability command. Threshold values were chosen depending on the device type as follows:

Dishwasher:

• Threshold: 90 degrees
• Range: 33C - 90C / 91.4F - 194F

Laundry Dryer:

• Threshold: 80 degrees
• Range: 27C - 80C / 80.6F - 176F

Laundry Washer:

• Threshold: 55 degrees
• Range: 13C - 55C / 55.4F - 131F

Refrigerator:

• Threshold: 20 degrees
• Range: -6C - 20C / 21.2F - 68F

Thermostat / Room AC:

• Threshold: 40 degrees
• Range: 5C - 40C / 41F - 104F

Please let me know if you have any opinions on better values to use.

Summary of Completed Tests

See new unit tests.

Testing with VDA:

• For each device, verify the correct range is present in both deg C and F, and that attempting to exceed the bounds in either direction results in the app displaying "Out of range". Note that the range that displays in the ST app will not necessarily be the max range defined in the drivers.
• [x] Dishwasher *
  • On VDA v1.3.4, this device crashes a few seconds after onboarding and the device appears as offline in the ST app.
    • This is fixed in v1.3.5.
  • The plugin only allows the setpoint value to go up to 100 F, even though the range displays correctly as 91.4 F - 194.0 F. The '+' becomes grayed out and the setpoint cannot be increased further. The slider works correctly in C. This issue is tracked by MTR-842.
• [x] Laundry Dryer *
• [x] Laundry Washer *
• [x] Refrigerator *
  • On VDA v1.3.4, this device crashes a few seconds after onboarding and the device appears as offline in the ST app.
  • This is fixed in v1.3.5.
• [x] Thermostat / Room AC
  • VDA Thermostat device sends Null values for the MinMeasuredValue and MaxMeasuredValue attributes of the temperatureMeasurement cluster. The temperature range displays as the plugin default of -20 to 50 *C, but this functionality is covered by unit tests.

* For these device types, the plugin is not correctly limiting the setpoint sliders from exceeding the allotted range. The minimum and maximum allowed values appear as expected, but the user is able to go beyond the range using the '-' and '+' buttons, which are not grayed out when the slider is at the min or max as they should be. Also, the slider can sometimes be moved beyond the range with sliding as well. The thermostat device type does not have this issue. This issue is tracked by MTR-841.

[github-actions[bot]]

Channel deleted.

[github-actions[bot]]

Test Results

   64 files    399 suites   0s :stopwatch: 1 986 tests 1 986 :white_check_mark: 0 :zzz: 0 :x: 3 427 runs  3 427 :white_check_mark: 0 :zzz: 0 :x:

Results for commit ebbdbb7e.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

matter-appliance_coverage.xml

File	Coverage
All files	72%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-appliance/src/matter-dishwasher/init.lua	68%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-appliance/src/matter-microwave-oven/init.lua	82%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-appliance/src/matter-extractor-hood/init.lua	98%	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-appliance/src/matter-oven/init.lua	85%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-appliance/src/embedded-cluster-utils.lua	45%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-appliance/src/init.lua	56%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-appliance/src/matter-cook-top/init.lua	85%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-appliance/src/matter-refrigerator/init.lua	65%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-appliance/src/matter-laundry/init.lua	69%	:x:

matter-thermostat_coverage.xml

File	Coverage
All files	83%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-appliance/src/matter-dishwasher/init.lua	68%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-appliance/src/matter-microwave-oven/init.lua	82%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-appliance/src/matter-extractor-hood/init.lua	98%	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-appliance/src/matter-oven/init.lua	85%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-appliance/src/embedded-cluster-utils.lua	45%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-appliance/src/init.lua	56%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-appliance/src/matter-cook-top/init.lua	85%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-appliance/src/matter-refrigerator/init.lua	65%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-appliance/src/matter-laundry/init.lua	69%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua	85%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua	42%	:x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against ebbdbb7e8d2455240b780a7a906fdc446484a67d

[LEE-HYOJUNG27]

I think you need to modify the temperature range for each device types. Because Celsius and Fahrenheit written in the description do not actually match and can cause conflict.

[Example of conflict]

Laundry Dryer: Threshold: 80 degrees Range: 26C - 80C / 81F - 178F

-> Range: 26C - 80C / 78.8F - 176F -> Conflict range : 78.8F - 80F

[Recalculated range]

Dishwasher: Threshold: 90 degrees Range: 33C - 90C / 91.4F - 194F

Laundry Dryer: Threshold: 80 degrees Range: 27C - 80C / 80.6F - 176F

Laundry Washer: Threshold: 55 degrees Range: 13C - 55C / 55.4F - 131F

Refrigerator: Threshold: 20 degrees Range: -6C - 20C / 21.2F - 68F

Thermostat / Room AC: Threshold: 39 degrees Range: 5C - 39C / 41F - 102.2F

cc: @HunsupJung

[nickolas-deboom]

I think you need to modify the temperature range for each device types. Because Celsius and Fahrenheit written in the description do not actually match and can cause conflict.

[Example of conflict]

Laundry Dryer: Threshold: 80 degrees Range: 26C - 80C / 81F - 178F

-> Range: 26C - 80C / 78.8F - 176F -> Conflict range : 78.8F - 80F

[Recalculated range]

Dishwasher: Threshold: 90 degrees Range: 33C - 90C / 91.4F - 194F

Laundry Dryer: Threshold: 80 degrees Range: 27C - 80C / 80.6F - 176F

Laundry Washer: Threshold: 55 degrees Range: 13C - 55C / 55.4F - 131F

Refrigerator: Threshold: 20 degrees Range: -6C - 20C / 21.2F - 68F

Thermostat / Room AC: Threshold: 39 degrees Range: 5C - 39C / 41F - 102.2F

cc: @HunsupJung

I applied these new ranges in b6c2b0853c580cc6ae4bedde861a8b78d7b8e274!