Open pInksenberg opened 3 weeks ago
Invitation URL: https://bestow-regional.api.smartthings.com/invite/6Vjdnbw5Nv2N
63 files 396 suites 0s :stopwatch: 1 937 tests 1 914 :white_check_mark: 0 :zzz: 23 :x: 3 361 runs 3 338 :white_check_mark: 0 :zzz: 23 :x:
For more details on these failures, see this check.
Results for commit 447740d3.
:recycle: This comment has been updated with latest results.
File | Coverage | |
---|---|---|
All files | 51% |
:x: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-window-covering/src/init.lua | 51% |
:x: |
Minimum allowed coverage is 90%
Generated by :monkey: cobertura-action against 447740d35102bfcb323773e2c028f9f0df87fb3f
Check all that apply
Type of Change
Checklist
Description of Change
The previous matter-window-covering edge driver use CurrentPositionLiftPercent100ths and OperationalStatus to decide window covering status (opening/open/closing/closed/partially open). However, sometimes operational status event comes first and sometimes position event comes first, makes the code logic complex. To simplify the code, TargetPositionLiftPercent100ths and CurrentPositionLiftPercent100ths are now used to decide the status of window covering without considering which attribute event comes first.
Summary of Completed Tests