Prevent multiple reads of MinSetpointDeadBand

[nickolas-deboom]

Type of Change

• [ ] WWST Certification Request
  • If this is your first time contributing code:
    • [ ] I have reviewed the README.md file
    • [ ] I have reviewed the CODE_OF_CONDUCT.md file
    • [ ] I have signed the CLA
  • [ ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
• [x] Bug fix
• [ ] New feature
• [ ] Refactor

Checklist

• [x] I have performed a self-review of my code
• [ ] I have commented my code in hard-to-understand areas
• [ ] I have verified my changes by testing with a device or have communicated a plan for testing
• [ ] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

CHAD-14135

The driver currently attempts to only read MinSetpointDeadBand once during the first time device_init is called, but the MIN_SETPOINT_DEADBAND_CHECKED field is not persisted, so the read request is sent during each device init. This is contributing to a spike in InteractionQueueFull exceptions. This change ensures that the field is persisted so that the read request is only sent once.

Summary of Completed Tests

Added unit test to verify that the MIN_SETPOINT_DEADBAND_CHECKED flag is set after the MinSetpointDeadBand attribute is received to ensure that this value is only read one time.

Tested with a VDA bridge consisting of 20 thermostats and 20 color temperature lights to ensure that no regressions were introduced. Note that the issue is still present when dealing with a large number of bridged devices because the queue can still reach capacity even with this change. This is meant to help alleviate the issue rather than provide a full solution, which would require optimizations to the read request logic in the firmware.

[github-actions[bot]]

Channel deleted.

[github-actions[bot]]

Test Results

   64 files    396 suites   0s :stopwatch: 1 938 tests 1 938 :white_check_mark: 0 :zzz: 0 :x: 3 362 runs  3 362 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 4a756889.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

File	Coverage
All files	82%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua	42%	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua	85%	:x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against 4a75688963782aa151a8df644b4904dcfa619d84