SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0

269 stars 462 forks source link

Convert Power and Energy reads from mW(h) to W(h). #1691

Closed hcarter-775 closed 1 month ago

hcarter-775 commented 1 month ago

Check all that apply

Type of Change

[ ] WWST Certification Request
- If this is your first time contributing code:
  - [ ] I have reviewed the README.md file
  - [ ] I have reviewed the CODE_OF_CONDUCT.md file
  - [ ] I have signed the CLA
- [ ] I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
[ ] Bug fix
[ ] New feature
[ ] Refactor

Checklist

[X] I have performed a self-review of my code
[X] I have commented my code in hard-to-understand areas
[ ] I have verified my changes by testing with a device or have communicated a plan for testing
[ ] I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

The Electrical Energy Measurement cluster and Electrical Power Measurement cluster report readings in mWh and mW respectively, but SmartThings uses W and Wh for our capabilities. This change converts the read values into those of the correct unit.

Summary of Completed Tests

Unit tests were converted to match the new system. See user testing reports in this Slack page:

github-actions[bot] commented 1 month ago

Channel deleted.

github-actions[bot] commented 1 month ago

Test Results

64 files ±0 396 suites ±0 0s :stopwatch: ±0s 1 938 tests ±0 1 938 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0 3 362 runs ±0 3 362 :white_check_mark: ±0 0 :zzz: ±0 0 :x: ±0

Results for commit e3fac2b4. ± Comparison against base commit 534b87c7.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 month ago

File	Coverage
All files	`93%`	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua	`96%`	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua	`91%`	:white_check_mark:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded-cluster-utils.lua	`38%`	:x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/aqara-cube/init.lua	`91%`	:white_check_mark:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against e3fac2b4ab77e5e256575c42aaa6ee9177f142d6