search

SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
269 stars 462 forks source link

fix: luacov-cobertura dependency acquisition #1695

Closed dljsjr closed 1 month ago

dljsjr commented 1 month ago

The version of luacov-cobertura on Luarocks is no longer available on github, and the rockspec we're downloading uses the GitHub source URL in its source definition, so we're failing to acquire it.

There's an alternative rockspec for this package, that's even recommended by the README of luacov, but it's not on Luarocks. So we acquire it from its release tag on GitHub.

The sed one-liners are because the rockspec from the tag reference the artifact from master instead of the artifact from the tag itself, and the version number wasn't properly incremented.

This will need to be hotfixed to Beta and Prod once we're happy with it

github-actions[bot] commented 1 month ago

Invitation URL: https://bestow-regional.api.smartthings.com/invite/WnlLL3ZZEzlK

github-actions[bot] commented 1 month ago

Test Results

   64 files    396 suites   0s :stopwatch: 1 938 tests 1 938 :white_check_mark: 0 :zzz: 0 :x: 3 362 runs  3 362 :white_check_mark: 0 :zzz: 0 :x:

Results for commit c4e4ad04.

github-actions[bot] commented 1 month ago

File Coverage
All files 79% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-evse/src/embedded_cluster_utils.lua 78% :x:
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-evse/src/init.lua 79% :x:

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against c4e4ad04ce9c5d774d2ad428a81586995498eb79