SmartThingsCommunity / SmartThingsEdgeDrivers

Apache License 2.0
269 stars 462 forks source link

fp2: add get_credential failure handling #1719

Closed hdlee27 closed 6 days ago

hdlee27 commented 1 month ago

Check all that apply

Type of Change

Checklist

Description of Change

When 403 error occurs after get_credential during device registration, the driver is waiting for socket timeout to occur while calling fill_body().

In the event of a 403 error, there is no need to fill the body, so in this case, the fill_body() is not called and treated as an error so that a quick return can be made.

This will help users with multiple devices quickly register their devices.

In addition, the log was changed more clearly when get_creditial failed.

Summary of Completed Tests

complete fp2 registration test on V3

github-actions[bot] commented 1 month ago

Test Results

   64 files    400 suites   0s ⏱️ 1 989 tests 1 989 ✅ 0 💤 0 ❌ 3 429 runs  3 429 ✅ 0 💤 0 ❌

Results for commit a1104755.

github-actions[bot] commented 1 month ago

Minimum allowed coverage is 90%

Generated by :monkey: cobertura-action against a1104755a06944b500e718509e69703c45230a0d

github-actions[bot] commented 1 month ago

Channel deleted.