Closed lelandblue closed 1 week ago
Channel deleted.
64 files ±0 400 suites ±0 0s ⏱️ ±0s 1 993 tests +4 1 993 ✅ +4 0 💤 ±0 0 ❌ ±0 3 433 runs +4 3 433 ✅ +4 0 💤 ±0 0 ❌ ±0
Results for commit acc4f5db. ± Comparison against base commit 3cbcc935.
:recycle: This comment has been updated with latest results.
File | Coverage | |
---|---|---|
All files | 94% |
:white_check_mark: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua | 91% |
:white_check_mark: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua | 96% |
:white_check_mark: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded-cluster-utils.lua | 38% |
:x: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/aqara-cube/init.lua | 96% |
:white_check_mark: |
Minimum allowed coverage is 90%
Generated by :monkey: cobertura-action against 05640b1ba384027b06b3f7ec1fd701add52022e8
@nickolas-deboom or @hcarter-775 Would a better fit for this device be the plug-binary profile?
@nickolas-deboom or @hcarter-775 Would a better fit for this device be the plug-binary profile?
Yeah I would say plug-binary seems to be a better fit - the same capabilities but uses the SmartPlug category rather than Switch.
@nickolas-deboom Thank you I have changed this.
@nickolas-deboom or @hcarter-775 Would a better fit for this device be the plug-binary profile?
Yeah I would say plug-binary seems to be a better fit - the same capabilities but uses the SmartPlug category rather than Switch.
Can you review this PR today by chance please?
@nickolas-deboom Thank you I have changed this.
@nickolas-deboom or @hcarter-775 Would a better fit for this device be the plug-binary profile?
Yeah I would say plug-binary seems to be a better fit - the same capabilities but uses the SmartPlug category rather than Switch.
Can you review this PR today by chance please?
Ok great! I am ready to approve now, but had one more quick question. The deviceLabel being used is "U-tec Smart Matter Plug" while the Product Name in the DCL is "U-tec Smart Plug". I can't remember - are these supposed to match exactly or does that not matter?
Edit: As discussed offline, the deviceLabel is usually the name provided by the partner.
Invitation URL: https://bestow-regional.api.smartthings.com/invite/adMKDaJBgW29
Check all that apply
Type of Change
Checklist
Description of Change
WWST Fingerprint submission for a Matter outlet. According to the DCL the Matter Device Type for this device is "x10A".
Summary of Completed Tests