Closed HunsupJung closed 1 week ago
Channel deleted.
64 files 400 suites 0s ⏱️ 1 993 tests 1 993 ✅ 0 💤 0 ❌ 3 433 runs 3 433 ✅ 0 💤 0 ❌
Results for commit be700751.
:recycle: This comment has been updated with latest results.
File | Coverage | |
---|---|---|
All files | 83% |
:x: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua | 42% |
:x: |
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua | 85% |
:x: |
Minimum allowed coverage is 90%
Generated by :monkey: cobertura-action against be7007518835f823e6acb92b90fda9ef7217ed22
I think the test cases will just need to be updated to expect state_change = true
when the capabilities are emitted!
I tested this PR using a cooling setpoint of 79 F and heating setpoint of 61 F, and then verified that when the heating setpoint is set to a value within the deadband, 78 F for example, the capability is reset back to 61 F and it reflects in the plugin.
Check all that apply
Type of Change
Checklist
Description of Change
There's a issue that if the setpoint is set to a value which is in the deadband range, the setpoint of device isn't set to the value and the setpoint of SmartThings plugin keeps the value. You can refer to below link for detail. https://smartthings.atlassian.net/browse/IOTE-4626
Summary of Completed Tests