SmartThingsCommunity / smartapp-sdk-nodejs

Javascript/NodeJS SDK to create SmartThings SmartApps
https://smartthings.developer.samsung.com/
Apache License 2.0
146 stars 80 forks source link

i18n for defaultValue of TextSetting #125

Closed MJ17 closed 4 years ago

MJ17 commented 4 years ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

-> I'm developing a smartapp using this SDK. I'm trying to apply localization in my app. I tried to set default value of text setting applying i18n, but it doesn't seem to work.

Describe the solution you'd like A clear and concise description of what you want to happen.

-> add some code in the constructor of TextSetting

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

-> or just do not support i18n. Show the same default message regardless of users' launguage setting.

Additional context Add any other context or screenshots about the feature request here.

-> this._defaultValue = this.i18nKey('defaultValue')

bflorian commented 4 years ago

Issue resolved with above PR