SmartThingsCommunity / smartapp-sdk-nodejs

Javascript/NodeJS SDK to create SmartThings SmartApps
https://smartthings.developer.samsung.com/
Apache License 2.0
146 stars 80 forks source link

fix: applied translateDefaultValue to SectionSettings #131

Closed lukhong closed 4 years ago

lukhong commented 4 years ago

Previous PR #127 broke the behavior of textSetting that was showing nothing properly when the defaultValue was not specified. To restore that break, I've added translateDefaultValue() to SectionSettings to handle only the case of using locales.

Types of changes

lukhong commented 4 years ago

@bflorian Applied your review and I just changed the target class to SectionSettings which has defaultValue originally.