chore: update dependencies and node version

SmartThingsCommunity / smartthings-cli

Command-line Interface for the SmartThings APIs.

https://developer.smartthings.com/docs/sdks/cli/introduction

Apache License 2.0

241 stars 104 forks source link

chore: update dependencies and node version #625

Closed rossiam closed 2 months ago

rossiam commented 2 months ago

updated Node to version 22
updated dependencies
- skipped inquirer because it will require more work. There is a new version we should switch to soon anyway.
- eslint held to 8.x version (for now)
  - eslint-plugin-import does not support eslint 9 and probably won't for a while
  - we may want to consider alternatives
  - maybe this will help?: https://prog.world/setting-up-eslint-plugin-import-for-new-eslint-version-9/
- changes to login-authenticator and its tests were ported from main branch because of core SDK update (I will skip merging the change that does this since it's done here)

changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: 2d36e2ff8b4a4cd51cf08baca586f504a334586c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sitlintac commented 2 months ago

The build failed on ubuntu because many definitions for es-lint rules couldn't be found. It succeeded on the other platforms. I skimmed the release notes and the issues for the typescript-eslint plugin and nothing jumped out at me; should we just re-run that test to see if it was a fluke?

rossiam commented 2 months ago

The build failed on ubuntu because many definitions for es-lint rules couldn't be found. It succeeded on the other platforms. I skimmed the release notes and the issues for the typescript-eslint plugin and nothing jumped out at me; should we just re-run that test to see if it was a fluke?

It seems some rules have moved to new plugins. I must have forgotten to run the linter locally. I don't know why the other environments succeeded.

To fix it, I installed the @stylistic/eslint-plugin package, added @stylistic to the plugins imported by eslint and updated the rules.

https://eslint.style/guide/migration