search

SmartThingsCommunity / st-device-sdk-c

SmartThings SDK for Direct Connected Devices for C
Other
118 stars 126 forks source link

Feature/q rgen #45

Closed grobebar closed 3 years ago

grobebar commented 3 years ago

This is a simple tool I wrote to read the data from onboarding_config.json and device_info.json (to minimize typo risk when generating QR codes manually). can be added to make file to generate QR code during build in dev environment

Kwang-Hui commented 3 years ago

Thanks for submitting PR. We are under reviewing your suggestion.

grobebar commented 3 years ago

When I run this on my linux machine, I got

./stdk-qrgen.py --folder ../../../apps/esp32/light_private/main/
ERROR: join() argument must be str or bytes, not 'PosixPath'

What Python version are you using?

I guess the culprit is "os.path.join(path, *paths) [...] Changed in version 3.6: Accepts a path-like object."

grobebar commented 3 years ago

@Kwang-Hui : Please check now. I have changed argument type to string

Kwang-Hui commented 3 years ago

When I run this on my linux machine, I got

./stdk-qrgen.py --folder ../../../apps/esp32/light_private/main/
ERROR: join() argument must be str or bytes, not 'PosixPath'

What Python version are you using?

I guess the culprit is "os.path.join(path, *paths) [...] Changed in version 3.6: Accepts a path-like object."

Oh. I used Python 3.5.2 for testing

grobebar commented 3 years ago

Is the updated code working with 3.5.2?