SmartThingsOSS / ratpack-cassandra

Other
14 stars 13 forks source link

BEE-1791: ValidationQuery per CassandraVersion #23

Closed travisgalloway-st closed 5 years ago

travisgalloway-st commented 5 years ago

Adds additional logic to check connected host version and uses an appropriate validation query for Cassandra v2 or v3.

v3 = "SELECT * FROM system_schema.keyspaces" v2 = "SELECT * FROM system.schema_keyspaces"

codecov[bot] commented 5 years ago

Codecov Report

Merging #23 into master will decrease coverage by 0.7%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #23      +/-   ##
============================================
- Coverage     34.04%   33.33%   -0.71%     
  Complexity        7        7              
============================================
  Files             6        6              
  Lines           141      141              
  Branches          6        8       +2     
============================================
- Hits             48       47       -1     
- Misses           87       88       +1     
  Partials          6        6
Impacted Files Coverage Δ Complexity Δ
...smartthings/ratpack/cassandra/CassandraModule.java 22.72% <ø> (-0.19%) 0 <0> (ø)
...things/ratpack/cassandra/CassandraHealthCheck.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 52e3ef9...ba5a6b7. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #23 into master will decrease coverage by 0.7%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #23      +/-   ##
============================================
- Coverage     34.04%   33.33%   -0.71%     
  Complexity        7        7              
============================================
  Files             6        6              
  Lines           141      141              
  Branches          6        8       +2     
============================================
- Hits             48       47       -1     
- Misses           87       88       +1     
  Partials          6        6
Impacted Files Coverage Δ Complexity Δ
...smartthings/ratpack/cassandra/CassandraModule.java 22.72% <ø> (-0.19%) 0 <0> (ø)
...things/ratpack/cassandra/CassandraHealthCheck.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 52e3ef9...ba5a6b7. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #23 into master will decrease coverage by 0.7%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #23      +/-   ##
============================================
- Coverage     34.04%   33.33%   -0.71%     
  Complexity        7        7              
============================================
  Files             6        6              
  Lines           141      141              
  Branches          6        8       +2     
============================================
- Hits             48       47       -1     
- Misses           87       88       +1     
  Partials          6        6
Impacted Files Coverage Δ Complexity Δ
...smartthings/ratpack/cassandra/CassandraModule.java 22.72% <ø> (-0.19%) 0 <0> (ø)
...things/ratpack/cassandra/CassandraHealthCheck.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 52e3ef9...ba5a6b7. Read the comment docs.

beckje01 commented 5 years ago

:+1: